Migrate proto generation to buf
#1139
Conversation
afritzler
force-pushed
the
enh/proto-generation
branch
3 times, most recently
from
109222f
to
5ade639
Compare
afritzler
force-pushed
the
enh/proto-generation
branch
from
5ade639
to
76d2d3b
Compare
- Migrate proto generation to `buf` - Update linter configuration - Fix linting issues
afritzler
force-pushed
the
enh/proto-generation
branch
from
76d2d3b
to
e46ff3e
Compare
|
|
||
| linters: | ||
| disable-all: true |
There was a problem hiding this comment.
Why do we first disable all linters? Isn't it possible to invert it? Enable all and disable the not needed linters?
There was a problem hiding this comment.
I agree with @lukasfrank, other projects (looked at prometheus and some grafana projects) use the same pattern to only disable unwanted linters. Golang CI Lint also adds linters with new updates which would be removed, as such you have the overhead to also review those changes as they come in. With an inverse you will eventually see failed golangcilint runs and can decide if this a valid issue or if the linter (or its check) should be disabled.
As per golangcilint documentation both enable-all and disable-all fields are false by default to achieve both patterns :)
| version: v2 | ||
| plugins: | ||
| # The protoc-gen-go stubs are required for grpc-go | ||
| - remote: buf.build/protocolbuffers/go |
There was a problem hiding this comment.
It seems like we are calling an external API by using a remote plugin.
We might want to get rid of it.
➜ ironcore git:(enh/proto-generation) ✗ buf generate
Failure: too many requests
Please see https://buf.build/docs/bsr/rate-limits for details about BSR rate limiting.
Proposed Changes
bufYou can now run the
protogeneration via:This will run the following command on the project:
The
bufconfiguration can be found in thebug.gen.yamlandbuf.yamlfiles in the project root.Fixes #1138